fix(fetch): decode response body when Location is set on non-3xx response #1628
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in #1554 cause the response body to not be decoded when a
Location
header is set and the request'sredirect
option is set tofollow
.For us this caused a few problems because we set the
Location
header on 201 responses to reference the location of the created resource. When looking at the spec, I don't think we're doing anything wrong on our end here.I updated the code to only skip decoding when the response code matches one of the codes defined as a
redirectStatus
as that's also what decides whether or not fetch is going to follow the redirect or not.