feat(fetch): allow setting base urls #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this change even wanted, or does it add ambiguity? I believe Deno offers a cli flag for doing something similar. Also, if a WPT test runner is ever added, will allow a majority of tests to run. |
Codecov Report
@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
+ Coverage 94.51% 94.95% +0.43%
==========================================
Files 49 51 +2
Lines 4799 4814 +15
==========================================
+ Hits 4536 4571 +35
+ Misses 263 243 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mcollina
requested changes
Sep 2, 2022
lib/fetch/global.js
Outdated
| 'use strict' | ||
|
|
||
| /** @type {undefined|URL} */ | ||
| let origin |
There was a problem hiding this comment.
I would use the same logic setGlobalDispatcher uses for this.
There was a problem hiding this comment.
Is it fine to add another symbol? Wasn't sure because of the issue linked above
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* feat(fetch): allow setting base url * add files :| * fix: set origin globally * fix: add docs
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* feat(fetch): allow setting base url * add files :| * fix: set origin globally * fix: add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Will not work between different undici versions (assetGlobalDispatcher/getGlobalDispatcherdo), because of undici leaking Symbol to global space in 18.2 (but not 18.1) node#43157.http:orhttps:urls.fetchcalls. This could come later, but I'd rather not add a million undici-only keys to RequestInit.Usage: