Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export some fetch utilities #1632

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Conversation

KhafraDev
Copy link
Member

These fetch utils are required for a spec-compliant version of XMLHttpRequest.

I'd like to make https://github.com/khafradev/undici/tree/xmlhttprequest into its own package and exporting these would allow me to do so. 馃槃

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #1632 (79ae8f0) into main (9ab4967) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1632   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          51       51           
  Lines        4816     4816           
=======================================
  Hits         4572     4572           
  Misses        244      244           
Impacted Files Coverage 螖
index-fetch.js 100.00% <100.00%> (酶)
index.js 100.00% <100.00%> (酶)
lib/fetch/index.js 84.10% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 84f56f7 into nodejs:main Sep 3, 2022
@KhafraDev KhafraDev deleted the export-fetch-util branch September 3, 2022 14:40
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants