-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WPT runner #1662
feat: WPT runner #1662
Conversation
Codecov ReportBase: 94.89% // Head: 94.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 53 53
Lines 4803 4803
=======================================
Hits 4558 4558
Misses 245 245 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Can you add it to CI? |
added to the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* feat: WPT runner * fix: add runner to ci
* feat: WPT runner * fix: add runner to ci
Implements a very basic WPT runner that should allow every test to run (theoretically - this PR only enables a single test to ensure that the runner is working).
The implementation is taken from https://github.com/KhafraDev/node-xmlhttprequest/tree/main/tests with some minor adjustments (setting exitCode on test failure, exiting if there are no tests to run).
Pros:
child_process.fork
) and communicates via ipc. This is because the xhr tests (from my package mentioned above) test synchronous requests that would block the thread and cause requests to never complete. This workaround probably isn't needed here but I decided not to make many changes.Cons