feat: add parameter to ProxyAgent options, which is type of authentication #1705
+88
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.11% // Head: 94.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 94.11% 94.19% +0.08%
==========================================
Files 53 53
Lines 4943 4961 +18
==========================================
+ Hits 4652 4673 +21
+ Misses 291 288 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
oooshima
changed the title
ronag
approved these changes
Oct 15, 2022
RafaelGSS
requested changes
Oct 15, 2022
lib/proxy-agent.js
Outdated
Comment on lines
61
to
63
| } | ||
|
|
||
| if (opts.token) { |
There was a problem hiding this comment.
Suggested change
| } | |
| if (opts.token) { | |
| } else if (opts.token) { |
lib/proxy-agent.js
Outdated
| @@ -55,10 +55,15 @@ class ProxyAgent extends DispatcherBase { | |||
| this[kProxyTls] = opts.proxyTls | |||
| this[kProxyHeaders] = {} | |||
|
|
|||
| // deprecated | |||
There was a problem hiding this comment.
Suggested change
| // deprecated | |
| // @deprecated in favour of opts.token |
| @@ -15,6 +15,7 @@ declare namespace ProxyAgent { | |||
| export interface Options extends Agent.Options { | |||
| uri: string; | |||
| auth?: string; | |||
There was a problem hiding this comment.
Suggested change
| auth?: string; | |
| /** | |
| * @deprecated use opts.token | |
| */ | |
| auth?: string; |
|
@RafaelGSS |
cola119
reviewed
Oct 16, 2022
docs/api/ProxyAgent.md
Outdated
|
|
||
| const proxyAgent = new ProxyAgent({ | ||
| uri: 'my.proxy.server', | ||
| token 'Bearer xxxx' |
There was a problem hiding this comment.
Suggested change
| token 'Bearer xxxx' | |
| token: 'Bearer xxxx' |
ronag
reviewed
Oct 16, 2022
mcollina
requested changes
Oct 16, 2022
oooshima
force-pushed
the
fix-proxyagent-authentication
branch
from
596b887 to
0ba193c
Compare
ronag
approved these changes
Oct 16, 2022
cola119
approved these changes
Oct 16, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
…ation (nodejs#1705) * feat: add parameter to ProxyAgent options, whitch is type of authentication. * fix: docs and comments * fix: docs * add: throw error when using auth in combination with token * add: test for the types Co-authored-by: oshimaharuna <ooooooshim115@gmail.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
…ation (nodejs#1705) * feat: add parameter to ProxyAgent options, whitch is type of authentication. * fix: docs and comments * fix: docs * add: throw error when using auth in combination with token * add: test for the types Co-authored-by: oshimaharuna <ooooooshim115@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: add parameter to ProxyAgent options
Benefits: ProxyAgent can use a variety of authentication types.
Also see: About this issue #1704