-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wpt: add scheme-blob.sub.any.js
#1707
Conversation
Codecov ReportBase: 94.19% // Head: 94.19% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 53 53
Lines 4957 4957
=======================================
Hits 4669 4669
Misses 288 288 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Do the WPT test contribute to the coverage? |
no, but it would be great if they did. |
I'm guessing it's not possible, maybe because of workers?
|
@mcollina wdyt? |
I tried using c8 as well, and although we get some results (not sure if they're accurate) it prevents the worker from exiting. 😕 |
scheme-blob.sub.any.js
test to ensure this works (file names with.sub
in them have substitutions in them).Two tests fail out of 17. One of the tests is entirely... wrong/broken, and the other is illogical. We pass more tests than Chrome/Firefox and the same 2 tests fail on Safari (see: results).