update llhttp to the latest version v8.1.0 #1718
Conversation
|
@mcollina please review |
Codecov ReportBase: 89.53% // Head: 89.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.01%
==========================================
Files 58 58
Lines 5257 5257
==========================================
+ Hits 4707 4708 +1
+ Misses 550 549 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Please update the llhttp wasm bundle |
|
Okay please, let me do so |
@mcollina , I've tried with different versions of Node.js and also tried various solutions online, but this error hinders me from updating the llhttp wasm bundle when i run Even with the latest version
|
|
You have a broken node/npm installation. You have likely installed node via brew/apt/* at some time and never removed it. On top, the nvm paths are misconfigured. |
|
@mcollina thank you for the feedback, on reinstalling node.js all worked fine. I have updated the wasm bundle |
|
Please run |
|
Okay please, let me do so |
|
@mcollina i fixed the linting |
* update deps/llhttp/includes and deps/lhttp/src to v8.1.0 * update the llhttp wasm bundle * ran npx standard --fix to adjust linting
* update deps/llhttp/includes and deps/lhttp/src to v8.1.0 * update the llhttp wasm bundle * ran npx standard --fix to adjust linting
This pr addresses #1710
deps/llhttp/srcanddeps/llhttp/includewith those from https://github.com/nodejs/llhttp/releases/tag/release%2Fv8.1.0npm run prebuild:wasmnpm run build:wasm