wpt: fail runner if expected failures don't fail #1736
Merged
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner will now fail if a test that is marked as an expected failure doesn't fail.
The way I did this is either ingenious or horrible, depending on how you look at it. It maps tests that failed to an object and then compares that object to a slightly modified version of the status file (without including other flags or flaky tests).
assertgives a very nice error message with exactly which test(s) did not fail (ie. tests that were not in both objects)I should also add that the order in which tests fail in is entirely deterministic such that the order in which tests fail in will never differ. The failures are mapped by the name of the file itself, similarly to the status files.