feat: allow connection header in request #1747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
Oct 29, 2022
| if (val.toLowerCase() === 'close') { | ||
| this.reset = true | ||
| } else if (val.toLowerCase() !== 'keep-alive') { | ||
| throw new InvalidArgumentError('invalid connection header') |
There was a problem hiding this comment.
What if there is a conflict between header and reset option?
There was a problem hiding this comment.
Should reset be always taking the prevalence?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to come up quite often. I'm opening this PR as stub for anyone that wants to finish it up. I think it mostly needs test and docs.
Refs: #1746
Refs: #1310
Refs: #1305
Refs: #444