Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement websockets #1795

Merged
merged 82 commits into from Dec 16, 2022
Merged

feat: implement websockets #1795

merged 82 commits into from Dec 16, 2022

Commits on Nov 28, 2022

  1. initial handshake

    @KhafraDev
    KhafraDev committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    bb688ac View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. minor fixes

    @KhafraDev
    KhafraDev committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    e6e2686 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. feat: working initial handshake!

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    9aea277 View commit details
    Browse the repository at this point in the history

  2. feat(ws): initial WebSocket class implementation

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f1ae69a View commit details
    Browse the repository at this point in the history

  3. fix: allow http: and ws: urls

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    bec82fd View commit details
    Browse the repository at this point in the history

  4. fix(ws): use websocket spec

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    7e6725e View commit details
    Browse the repository at this point in the history

  5. fix(ws): use websocket spec

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    5030683 View commit details
    Browse the repository at this point in the history

  6. feat: implement url getter

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    a928c58 View commit details
    Browse the repository at this point in the history

  7. feat: implement some of WebSocket.close and ready state

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ecff3d7 View commit details
    Browse the repository at this point in the history

  8. fix: body is null for websockets & pass socket to response

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    6ec2701 View commit details
    Browse the repository at this point in the history

  9. fix: store the fetch controller & response on ws

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    39c7b43 View commit details
    Browse the repository at this point in the history

  10. fix: remove invalid tests

    @KhafraDev
    KhafraDev committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    fb84cb8 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. feat: implement readyState getter

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    85a4046 View commit details
    Browse the repository at this point in the history

  2. feat: implement protocol and extensions getters

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    190cabe View commit details
    Browse the repository at this point in the history

  3. feat: implement event listeners

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    454a5c3 View commit details
    Browse the repository at this point in the history

  4. feat: implement binaryType attribute

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    5ae04ee View commit details
    Browse the repository at this point in the history

  5. fix: add argument length checks

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    c9ff83a View commit details
    Browse the repository at this point in the history

  6. feat: basic unfragmented message parsing

    @KhafraDev
    KhafraDev committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    484e732 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. fix: always remove previous listener

    @KhafraDev
    KhafraDev committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8619653 View commit details
    Browse the repository at this point in the history

  2. feat: add in idlharness WPT

    @KhafraDev
    KhafraDev committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c70bd8b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. implement sending a message for WS and add a websocketFrame class

    @jodevsa
    jodevsa committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    34758e6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #30 from jodevsa/ws 

    implement sending a message for WS and add a websocketFrame class
    @KhafraDev
    KhafraDev committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    6a6b1b3 View commit details
    Browse the repository at this point in the history

  3. feat: allow sending ArrayBuffer/Views & Blob

    @KhafraDev
    KhafraDev committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    a87e53b View commit details
    Browse the repository at this point in the history

  4. fix: remove duplicate upgrade and connection headers

    @KhafraDev
    KhafraDev committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    d983115 View commit details
    Browse the repository at this point in the history

  5. feat: add in WebSocket.close() and handle closing frames

    @KhafraDev
    KhafraDev committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    feee358 View commit details
    Browse the repository at this point in the history

  6. refactor WebsocketFrame and support receiving frames in multiple chunks

    @jodevsa
    jodevsa committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    5e61a84 View commit details
    Browse the repository at this point in the history

  7. fixes

    @jodevsa
    jodevsa committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    0e07468 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge pull request #31 from jodevsa/ws 

    refactor WebsocketFrame and support receiving frames in multiple chunks
    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    e288ea5 View commit details
    Browse the repository at this point in the history

  2. move WebsocketFrame to its own file

    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    cbad426 View commit details
    Browse the repository at this point in the history

  3. feat: export WebSocket & add types

    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    d2462a1 View commit details
    Browse the repository at this point in the history

  4. fix: tsd

    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1340dd4 View commit details
    Browse the repository at this point in the history

  5. feat(wpt): use WebSocketServer & run test

    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    8d98382 View commit details
    Browse the repository at this point in the history

  6. fix: properly set/read close code & close reason

    @KhafraDev
    KhafraDev committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    3cae2ec View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. fix: flakiness in websocket test runner

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    73c8389 View commit details
    Browse the repository at this point in the history

  2. fix: receive message with arraybuffer binary type

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    8b7bc44 View commit details
    Browse the repository at this point in the history

  3. feat: split WebsocketFrame into 2 classes (sent & received)

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    eb09dc6 View commit details
    Browse the repository at this point in the history

  4. fix: parse fragmented frames more efficiently & close frame

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    174c030 View commit details
    Browse the repository at this point in the history

  5. fix: add types for MessageEvent and CloseEvent

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    7ee907b View commit details
    Browse the repository at this point in the history

  6. fix: subprotocol validation & add wpts

    @KhafraDev
    KhafraDev committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6985bc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. fix: protocol validation & protocol webidl & add wpts

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    eae7f76 View commit details
    Browse the repository at this point in the history

  2. fix: correct bufferedAmount calc. & message event w/ blob

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    682d880 View commit details
    Browse the repository at this point in the history

  3. fix: don't truncate typedarrays

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    052a804 View commit details
    Browse the repository at this point in the history

  4. feat: add remaining wpts

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5f2fdab View commit details
    Browse the repository at this point in the history

  5. fix: allow sending payloads > 65k bytes

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6caaa47 View commit details
    Browse the repository at this point in the history

  6. fix: mask data > 125 bytes properly

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    2d5b9ae View commit details
    Browse the repository at this point in the history

  7. revert changes to core

    @KhafraDev
    KhafraDev committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    0880cef View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. fix: decrement bufferedAmount after write

    @KhafraDev
    KhafraDev committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    02805e8 View commit details
    Browse the repository at this point in the history

  2. fix: handle ping and pong frames

    @KhafraDev
    KhafraDev committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    58114ab View commit details
    Browse the repository at this point in the history

  3. fix: simplify receiving frame logic

    @KhafraDev
    KhafraDev committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    a099471 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. fix: disable extensions & validate frames

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    346bdb8 View commit details
    Browse the repository at this point in the history

  2. fix: send close frame upon receiving

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5113fb2 View commit details
    Browse the repository at this point in the history

  3. lint

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    dee913c View commit details
    Browse the repository at this point in the history

  4. fix: validate status code & utf-8

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b3c4314 View commit details
    Browse the repository at this point in the history

  5. fix: add hooks

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    7741277 View commit details
    Browse the repository at this point in the history

  6. fix: check if frame is unfragmented correctly

    @KhafraDev
    KhafraDev committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b1339fb View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. fix: send ping app data in pong frames

    @KhafraDev
    KhafraDev committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    61c921c View commit details
    Browse the repository at this point in the history

  2. export websocket on node >= 18 & add diagnostic_channels

    @KhafraDev
    KhafraDev committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    c7249d3 View commit details
    Browse the repository at this point in the history

  3. mark test as flaky

    @KhafraDev
    KhafraDev committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    aadf25a View commit details
    Browse the repository at this point in the history

  4. fix: couple bug fixes

    @KhafraDev
    KhafraDev committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    30b1e23 View commit details
    Browse the repository at this point in the history

  5. fix: fragmented frame end detection

    @KhafraDev
    KhafraDev committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    6a7134b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. fix: use TextDecoder for utf-8 validation

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    b6411a6 View commit details
    Browse the repository at this point in the history

  2. fix: handle incomplete chunks

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    4fbfbf4 View commit details
    Browse the repository at this point in the history

  3. revert: handle incomplete chunks

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    e43fa5b View commit details
    Browse the repository at this point in the history

  4. mark WebSockets as experimental

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    553a0f2 View commit details
    Browse the repository at this point in the history

  5. fix: sending 65k bytes is still flaky on linux

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    e0289f7 View commit details
    Browse the repository at this point in the history

  6. fix: apply suggestions

    @KhafraDev
    KhafraDev committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    dcc3801 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. fix: apply some suggestions

    @KhafraDev
    KhafraDev committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    797acc3 View commit details
    Browse the repository at this point in the history

  2. add basic docs

    @KhafraDev
    KhafraDev committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    dfc57ab View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. feat: use streaming parser for frames

    @KhafraDev
    KhafraDev committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a0094a4 View commit details
    Browse the repository at this point in the history

  2. feat: validate some frames & remove WebsocketFrame class

    @KhafraDev
    KhafraDev committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    883d9d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. fix: parse close frame & move failWebsocketConnection

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    71848d9 View commit details
    Browse the repository at this point in the history

  2. fix: read close reason and read entire close body

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b468029 View commit details
    Browse the repository at this point in the history

  3. fix: echo close frame if one hasn't been sent

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8839538 View commit details
    Browse the repository at this point in the history

  4. fix: emit message event on message receive

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    78b77a8 View commit details
    Browse the repository at this point in the history

  5. fix: minor fixes

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6cfc42e View commit details
    Browse the repository at this point in the history

  6. fix: ci

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    7f1b5d4 View commit details
    Browse the repository at this point in the history

  7. fix: set was clean exit after server receives close frame

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    24ae13b View commit details
    Browse the repository at this point in the history

  8. fix: check if received close frame for clean close

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    5086ce8 View commit details
    Browse the repository at this point in the history

  9. fix: set sent close after writing frame

    @KhafraDev
    KhafraDev committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    6441dc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. feat: implement error messages

    @KhafraDev
    KhafraDev committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    476a192 View commit details
    Browse the repository at this point in the history

  2. fix: add error event handler to socket

    @KhafraDev
    KhafraDev committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    28c7ff6 View commit details
    Browse the repository at this point in the history

  3. fix: address reviews

    @KhafraDev
    KhafraDev committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    73128fd View commit details
    Browse the repository at this point in the history