Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow h2 pseudo-header #2417

Closed
wants to merge 5 commits into from

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Nov 9, 2023

Needed for #2410

This relates to...

Fixes #2415

Rationale

See #2415

Changes

TODO

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (0c9c7dd) 85.71%.
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2417      +/-   ##
==========================================
+ Coverage   85.54%   85.71%   +0.16%     
==========================================
  Files          76       76              
  Lines        6858     6937      +79     
==========================================
+ Hits         5867     5946      +79     
  Misses        991      991              
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/api/api-stream.js 100.00% <100.00%> (ø)
lib/core/connect.js 80.00% <100.00%> (-1.25%) ⬇️
lib/fetch/body.js 97.68% <100.00%> (ø)
lib/fetch/constants.js 97.22% <100.00%> (+0.67%) ⬆️
lib/fetch/file.js 94.31% <100.00%> (-1.09%) ⬇️
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/response.js 97.04% <100.00%> (+1.20%) ⬆️
lib/fetch/util.js 86.20% <100.00%> (+0.38%) ⬆️
lib/fetch/webidl.js 94.50% <100.00%> (-0.03%) ⬇️
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsctx tsctx changed the title [WIP] feat: allow h2 pseudo-header feat: allow h2 pseudo-header Nov 10, 2023
@tsctx tsctx marked this pull request as ready for review November 10, 2023 07:24
@KhafraDev KhafraDev closed this Nov 10, 2023
@tsctx tsctx deleted the feat/allow-h2-pseudo-header branch November 10, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pseudo-header :status is included in h2 fetch.
3 participants