Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't propagate async scope across events #301

Merged
merged 1 commit into from
Aug 8, 2020
Merged

don't propagate async scope across events #301

merged 1 commit into from
Aug 8, 2020
+25 −51

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 6, 2020 •
edited

Don't propagate async scope across events.

Pending recommendation/consensus in nodejs/node#34430

Refs: nodejs/node#34430

Small perf boost:

undici - stream x 12,681 ops/sec ±1.95% (83 runs sampled)

vs

undici - stream x 12,226 ops/sec ±2.12% (80 runs sampled)

@ronag
Copy link
Member Author

ronag commented Aug 7, 2020

@mcollina Do you have any opinion on this or should we wait and see how nodejs/node#34430 turns out?

mcollina
mcollina approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Aug 8, 2020

I think this is the right path tbh

@ronag ronag merged commit 0cd575b into master Aug 8, 2020
@ronag ronag deleted the async2 branch August 8, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronag @mcollina