fix websocket receiving an invalid utf-8 in close frame

[KhafraDev]

Closes #3080

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.63636% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 94.19%. Comparing base (6866d29) to head (c22d8cb).
Report is 2 commits behind head on main.

Files	Patch %	Lines
lib/web/websocket/connection.js	94.66%	4 Missing ⚠️
lib/web/websocket/websocket.js	81.25%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
+ Coverage   94.17%   94.19%   +0.02%     
==========================================
  Files          90       90              
  Lines       24432    24464      +32     
==========================================
+ Hits        23009    23045      +36     
+ Misses       1423     1419       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Uzlopak]

But shouldnt 1007 be sent by the server if the message sent by the client is not valid?

[KhafraDev]

that's for the server to handle, this is the client

[Uzlopak]

So?

The spec says:

1007

  1007 indicates that an endpoint is terminating the connection
  because it has received data within a message that was not
  consistent with the type of the message (e.g., non-UTF-8 [[RFC3629](https://datatracker.ietf.org/doc/html/rfc3629)]
  data within a text message).

So, what happens is, that the websocket server is terminating/closing the websocket conenction, because thes server received invalid data. Where does the spec say, that the client is receiving an invalid frame, and thus returns 1007?

[KhafraDev]

I don't totally understand what you are asking:

• The server closes the connection for whatever reason. The close frame it sends has invalid utf-8 as its body.
• The client receives the frame, parses the body, sees it is invalid utf-8.
• The client emits an error.
• The client terminates the connection with the appropriate status code.
• Since the server sent a close frame, it will no longer send data to/read data from the client.
• Since the client never receives a response, and the server closed the connection, the status code defaults to 1006 (since the connection is closed & no response received. This is in the RFC).

That is why the server receives a 1007 status code, but the client receives a 1006 status code. The reason we send a 1007 status code is precisely for that section you linked.

[KhafraDev]

I tested with Deno (which has a bug in its implementation) and ws. This matches ws' behavior and the logic makes sense to me.

[mcollina]

lgtm

[KhafraDev]

onSocketClose is called once the socket is closed. By the RFC that means we are in the CLOSED state already, we just haven't set it yet.

[KhafraDev]

@Uzlopak PTAL

[Uzlopak]

After the last commit I love it.