Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use openpgp/ubuntu keyservers #39

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Jul 5, 2021

SKS no longer publishes DNS. Same approach from docker-node
Fixes #37

SKS no longer publishes DNS
@richardlau richardlau merged commit 630ff52 into nodejs:master Jul 5, 2021
@nschonni nschonni deleted the openpgp branch July 5, 2021 15:08
@nschonni
Copy link
Member Author

nschonni commented Jul 5, 2021

@richardlau thanks! Do the security release builds need to be manually re-triggered to re-run?

@richardlau
Copy link
Member

@nschonni I manually requeued them.

FYI the release team is planning releases today to fix a Windows installer regression in the security releases. Hopefully the process should just work with this PR merged and the unofficial builds occur automatically.

@nschonni
Copy link
Member Author

nschonni commented Jul 5, 2021

I wonder if the images need to be pushed out somehow. It looks like the new 12.22.2 still hit the old keyserver https://unofficial-builds.nodejs.org/logs/202107011554-v12.22.2/fetch-source.log

@nschonni
Copy link
Member Author

nschonni commented Jul 5, 2021

Actually 12.22.3 seems OK now https://unofficial-builds.nodejs.org/logs/202107051602-v12.22.3/

@richardlau
Copy link
Member

I wonder if the images need to be pushed out somehow. It looks like the new 12.22.2 still hit the old keyserver https://unofficial-builds.nodejs.org/logs/202107011554-v12.22.2/fetch-source.log

🤦 I probably queued the builds too early and needed to wait for the images to rebuild (it's automatic on repository pushes). I'll queue them up again.

@nschonni
Copy link
Member Author

nschonni commented Jul 5, 2021

No worries. Looks like 12.22.3 completed successfully, but maybe the others are still in the queue

@richardlau
Copy link
Member

14.17.3 is in progress: https://unofficial-builds.nodejs.org/logs/202107051715-v14.17.3/

I did queue 16.4.1, 14.17.2 and 12.22.2 again -- I saw them queued and now they're not but I can't find any evidence they were rerun 😕.

@richardlau
Copy link
Member

14.17.3 is in progress: https://unofficial-builds.nodejs.org/logs/202107051715-v14.17.3/

I did queue 16.4.1, 14.17.2 and 12.22.2 again -- I saw them queued and now they're not but I can't find any evidence they were rerun 😕.

Found the logs (journalctl -u nodejs-periodic.service):

Jul 05 15:12:43 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[1518]: Unknown version: 16.4.1
Jul 05 15:17:44 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[1605]: Unknown version: 14.17.2
Jul 05 15:22:50 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[2167]: Unknown version: 12.22.2

Apparently I fail at reading 🤦:
https://github.com/nodejs/unofficial-builds/blob/master/README.md#manual-build-triggers

the "v" is necessary

@rvagg
Copy link
Member

rvagg commented Jul 6, 2021

cool, thanks for fixing, but the indenting .. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken build due to OpenPGP key servers problem
3 participants