feat: start scaffolding out packages and examples #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we may also want to set a loose rule of no package-locks as it'll only cause more problems than its worth imo for experimentation |
Co-authored-by: Ethan Arrowood <ethan.arrowood@gmail.com>
wesleytodd
commented
Oct 16, 2020
I almost committed the npmrc to do that. I agree, and if no one dissents I will push that change this weekend. |
|
I'm +1 for npmrc. Remember this stuff isn't meant to be taken too seriously. If someone really wants to commit a lock file we can let them |
|
also + 1 on both npmrc and package-lock |
antsmartian
reviewed
Oct 21, 2020
| # Example of using `h3xt` http framework | ||
|
|
||
| This is just a scratch pad for what an end user application built | ||
| ontop of the new framework could look like. |
There was a problem hiding this comment.
nit: Actually we can add the npm version requirement here:
This requires npm@7 workspaces. $ npm i -g npm@7 then run npm i in the root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #73, here is some of the example code I had been messing around with. As you can tell, there is no meat to this, it is simply meant to start working through what the layers structure would be and what the API's might look like.
As we discussed on the meeting and I proposed in #73, this is only to get something started. Merging this is not committing to any direction, and I hope strongly that we change all of this going forward. I am happy to delete much of this (I just copied in my notes) before merging and just keep the package scaffold, but figured I would do the minimum effort and just copy paste what I had into here to get started.
Note: This requires
npm@7workspaces.$ npm i -g npm@7then runnpm iin the root.