ISSUE-65: use 'files' field instead of '.npmignore' file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmlnc
force-pushed
the
ISSUE-65_use_package_files_field
branch
from
97a52eb
to
5faf9bb
Compare
|
Blocked by npm/cli#2038. |
|
Hi @mrmlnc any update on this, it seem the update from npm would take a while and currently the latest version deployed is broken and apps that update would also be broken in production systems. So this is pretty critical, it would be good to find a workaround on this |
|
Thousands of packages are distributed through npm along with TS tests that come to the user in node modules. Having tests in the package should not break your build if it is configured correctly. This is confirmed by the lack of mass character of the problem. |
mrmlnc
force-pushed
the
ISSUE-65_use_package_files_field
branch
4 times, most recently
from
a5982d5
to
e624ca0
Compare
mrmlnc
force-pushed
the
ISSUE-65_use_package_files_field
branch
from
e624ca0
to
9709042
Compare
|
Yes @mrmlnc you correct, we did not exclude node_modules during tests. Thanks for pointing out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#65