Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MongoBinaryDownloadUrl): support Debian 12 (Bookworm) #858

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

pnordhus
Copy link
Contributor

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (fca7981) to head (6d7a7f1).
Report is 1 commits behind head on master.

❗ Current head 6d7a7f1 differs from pull request most recent head 90c3f2d. Consider uploading reports for the commit 90c3f2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   91.16%   91.29%   +0.12%     
==========================================
  Files          15       15              
  Lines        1992     1998       +6     
  Branches      502      506       +4     
==========================================
+ Hits         1816     1824       +8     
+ Misses        167      165       -2     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing those changes, the only thing missing is to update the docs.
Do you want to do this, or should i do it after the merge?

@pnordhus
Copy link
Contributor Author

@hasezoey Good point! I think it makes sense to include the doc update in this PR. Updated ☺️

@pnordhus pnordhus requested a review from hasezoey March 28, 2024 17:56
@hasezoey hasezoey added the Distribution support Add / modify an (linux) distribution label Mar 28, 2024
@hasezoey hasezoey merged commit 48dbf43 into nodkz:master Mar 28, 2024
7 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Distribution support Add / modify an (linux) distribution released Pull Request released | Issue is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants