Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-runners.md #866

Merged
merged 1 commit into from Apr 22, 2024
Merged

Update test-runners.md #866

merged 1 commit into from Apr 22, 2024

Conversation

Darkmift
Copy link
Contributor

  • fixed doc to reflect proper API (current example caused crashes for me)

Related Issues

- fixed doc to reflect proper API (current example caused crashes for me)
@hasezoey
Copy link
Collaborator

current example caused crashes for me

are you running ESM or CommonJS?

@Darkmift
Copy link
Contributor Author

current example caused crashes for me

are you running ESM or CommonJS?

ESM

@hasezoey
Copy link
Collaborator

hasezoey commented Apr 22, 2024

the example works and has been tested in CommonJS, in ESM it likely does not work as mongoose does not export connection there (as ESM does not allow changing the export once set)
reference

@hasezoey hasezoey changed the base branch from master to beta April 22, 2024 11:42
@hasezoey hasezoey merged commit ea21ffc into nodkz:beta Apr 22, 2024
7 checks passed
Copy link

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Pull Request released | Issue is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants