Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

fix(test): cannot collect *.vue coverage #48

Merged
merged 1 commit into from Mar 3, 2020

Conversation

nogic1008
Copy link
Owner

@nogic1008 nogic1008 commented Mar 3, 2020

In jest 25.1.0, coverage data is only collected from JavaScript files.
This PR reverts jest to 24 for workaround.

Before

------------------|---------|----------|---------|---------|-------------------
File              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------|---------|----------|---------|---------|-------------------
All files         |     100 |      100 |     100 |     100 |                   
 plugins          |     100 |      100 |     100 |     100 |                   
  environments.ts |     100 |      100 |     100 |     100 |                   
  vuex-module.ts  |     100 |      100 |     100 |     100 |                   
 store            |     100 |      100 |     100 |     100 |                   
  counter.ts      |     100 |      100 |     100 |     100 |                   
  index.ts        |     100 |      100 |     100 |     100 |                   
 types            |       0 |        0 |       0 |       0 |                   
  vue-shim.d.ts   |       0 |        0 |       0 |       0 |                   
 utils            |     100 |      100 |     100 |     100 |                   
  test-utils.ts   |     100 |      100 |     100 |     100 |                   
------------------|---------|----------|---------|---------|-------------------

After

------------------|----------|----------|----------|----------|-------------------|
File              |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
------------------|----------|----------|----------|----------|-------------------|
All files         |      100 |      100 |      100 |      100 |                   |
 components       |      100 |      100 |      100 |      100 |                   |
  Card.vue        |      100 |      100 |      100 |      100 |                   |
  Counter.vue     |      100 |      100 |      100 |      100 |                   |
 layouts          |      100 |      100 |      100 |      100 |                   |
  default.vue     |      100 |      100 |      100 |      100 |                   |
 pages            |      100 |      100 |      100 |      100 |                   |
  environment.vue |      100 |      100 |      100 |      100 |                   |
  index.vue       |      100 |      100 |      100 |      100 |                   |
  inspire.vue     |      100 |      100 |      100 |      100 |                   |
 plugins          |      100 |      100 |      100 |      100 |                   |
  environments.ts |      100 |      100 |      100 |      100 |                   |
  vuex-module.ts  |      100 |      100 |      100 |      100 |                   |
 store            |      100 |      100 |      100 |      100 |                   |
  counter.ts      |      100 |      100 |      100 |      100 |                   |
  index.ts        |      100 |      100 |      100 |      100 |                   |
 types            |        0 |        0 |        0 |        0 |                   |
  vue-shim.d.ts   |        0 |        0 |        0 |        0 |                   |
 utils            |      100 |      100 |      100 |      100 |                   |
  test-utils.ts   |      100 |      100 |      100 |      100 |                   |
------------------|----------|----------|----------|----------|-------------------|

Ref

@nogic1008 nogic1008 added invalid:warning: This doesn't seem right (warning, typo...) development:rocket: Area development (testing, deploy...) labels Mar 3, 2020
@nogic1008 nogic1008 added this to the v1.2 milestone Mar 3, 2020
@commit-lint
Copy link

commit-lint bot commented Mar 3, 2020

Chore

  • deps-dev: revert jest to 24 (5beb202)

Contributors

@nogic1008

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5     11    +6     
  Lines          37     67   +30     
  Branches        4      4           
=====================================
+ Hits           37     67   +30
Impacted Files Coverage Δ
pages/index.vue 100% <0%> (ø)
pages/inspire.vue 100% <0%> (ø)
components/Counter.vue 100% <0%> (ø)
pages/environment.vue 100% <0%> (ø)
components/Card.vue 100% <0%> (ø)
layouts/default.vue 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09db0b...5beb202. Read the comment docs.

@nogic1008 nogic1008 merged commit c4fad5f into master Mar 3, 2020
@nogic1008 nogic1008 deleted the hotfix/vue-file-coverage branch March 3, 2020 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
development:rocket: Area development (testing, deploy...) invalid:warning: This doesn't seem right (warning, typo...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant