Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort imports with isort's mode 11 #531

Merged
merged 2 commits into from Sep 3, 2020
Merged

Sort imports with isort's mode 11 #531

merged 2 commits into from Sep 3, 2020

Conversation

nolar
Copy link
Owner

@nolar nolar commented Sep 3, 2020

What do these changes do?

Apply isort's new mode 11 — a grid, but without parentheses. For the beauty of it.

Description

Just for the beauty of it.

The mode was added recently: PyCQA/isort#1434

Before (mode 0):

image

After (mode 11):

image

Also, ensure that isort is present in CI (was forgotten before).

Issues/PRs

Issues: a follow-up for #525.

Related:

Type of changes

  • Refactoring (non-breaking change which does not alter the behaviour)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar nolar added the refactoring Code cleanup without new features added label Sep 3, 2020
@nolar nolar mentioned this pull request Sep 3, 2020
Closed
@nolar nolar merged commit 39b12e4 into master Sep 3, 2020
@nolar nolar deleted the isort-mode-11 branch September 3, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Code cleanup without new features added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nolar