[hardhat-ethers] getContractFactory and getContractAt should have an overload that take an Artifact
#1716
Assignees
Labels
good-first-issue
Good for newcomers. Guidance available if needed
Comments
alcuadrado
added
good-first-issue
fvictorio
changed the title
getContractFactory and getCotractAt should have an overload that take an ArtifactgetContractFactory and getContractAt should have an overload that take an Artifact
|
is this issue still open ? |
|
Yes, do you want to implement it? |
|
Ya... I want to give it a try since it's a good first issue . So I think I can do this |
|
This is a good first issue for you, @Rishabhraghwendra18 |
kanej
added a commit
that referenced
this issue
Nov 30, 2021
Allow passing of artifacts (resolved via custom code) into the `getContractFactory` call, this is instead of resolving by contract name. Relates to #1716.
Merged
4 tasks
kanej
added a commit
that referenced
this issue
Dec 1, 2021
Let users pass in their own `Artifact` instance to `getContractAt`, this is mainly to maintain parity with `getContractFactory`. Relates to #1716.
kanej
added a commit
that referenced
this issue
Dec 1, 2021
…tifact`s Allow passing of artifacts (resolved via custom code) into the `getContractFactory` and `getContractAt` calls, this is instead of resolving by contract name. Relates to #1716.
kanej
added a commit
that referenced
this issue
Dec 1, 2021
…tifact`s Allow passing of artifacts (resolved via custom code) into the `getContractFactory` and `getContractAt` calls, this is instead of resolving by contract name. Relates to #1716.
kanej
added a commit
that referenced
this issue
Dec 7, 2021
…romArtifact` Allow passing of artifacts (resolved via custom code) into equivalents of `getContractFactory` and `getContractAt` calls, this is to support custom artifact resolution. Relates to #1716.
kanej
added a commit
that referenced
this issue
Dec 7, 2021
…romArtifact` Allow passing of artifacts (resolved via custom code) into equivalents of `getContractFactory` and `getContractAt` calls, this is to support custom artifact resolution. Relates to #1716.
Merged
4 tasks
Merged
|
This will get closed when the release goes out. |
|
Done in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This was reported by @nventuro
If you have your own artifacts-loading logic, and have a contract that needs to be linked, our plugin doesn't help you. You'd have to link the libraries manually.
We should have overloads that take an
Artifact, and take care of the library linking.getContractAtdoesn't really need this overload, but it would be great to be consistent.The text was updated successfully, but these errors were encountered: