Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS and TS coloring #142

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix JS and TS coloring #142

wants to merge 9 commits into from

Conversation

svipas
Copy link

@svipas svipas commented Jun 13, 2019 •
edited

  • JS & TS scopes and styles are consistent.
  • Their order of scopes are the same and they both contain the same amount of scopes needed. This means TS now have fixed interpolated string templates, JS now contains color for class initialization and so on.
  • Remove bold font style from Entity Other Inherited Class.
  • Add JSX inner text scope for TS and JS.
  • Add Node.js global variables support for JS and TS.
  • Add missing meta.brace.round () and meta.brace.square [] scopes.

Fixes #120

@svipas svipas requested a review from svengreb as a code owner June 13, 2019 08:20
@svipas svipas mentioned this pull request Jun 13, 2019
Open
@svipas
Copy link
Author

svipas commented Oct 4, 2019

Hi @arcticicestudio, there's still an issue with JS & TS color inconsistencies, if you want I can fix conflicts of this PR.

@svipas svipas mentioned this pull request Oct 29, 2019
Closed
@svengreb svengreb removed the request for review from arcticicestudio July 15, 2023 12:25
@svengreb
Copy link
Member

@svipas Thanks again for your contribution 🚀
The pull request has been added for triage and the review will be planned for the next iterations!

@svipas
Copy link
Author

svipas commented Jul 17, 2023

@svengreb Thanks for the best theme ever! This PR is pretty old and might require some work to do before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb Awaiting requested review from svengreb svengreb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
context-syntax scope-compatibility
Projects
Planning & Roadmaps
Status: triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS and JS inconsistencies
3 participants
@svipas @svengreb @arcticicestudio