Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update lint #804

Merged
merged 2 commits into from Jan 7, 2019
Merged

chore(deps): update lint #804

merged 2 commits into from Jan 7, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 31, 2018

This PR contains the following updates:

Package Type Update Change References
eslint devDependencies minor 5.11.0 -> 5.12.0 homepage, source
eslint-plugin-react devDependencies minor 7.11.1 -> 7.12.3 source
stylelint-scss devDependencies patch 3.4.3 -> 3.4.4 source

Release Notes

eslint/eslint

v5.12.0

Compare Source

v5.11.1

Compare Source

  • de79f10 Fix: handle optional catch bindings in no-useless-catch (#​11205) (Colin Ihrig)
yannickcr/eslint-plugin-react

v7.12.3

Compare Source

Fixed
Changed

v7.12.2

Compare Source

Fixed

v7.12.1

Compare Source

Fixed
Changed

v7.12.0

Compare Source

Added
Fixed
Changed
kristerkari/stylelint-scss

v3.4.4

Compare Source

  • Updated: postcss-selector-parser dependency to 5.0.0 (major version bump) with a memory leak fix and other bug fixes.

Renovate configuration

📅 Schedule: "on monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the Renovate 🌴 Dependency update label Dec 31, 2018
@DalderupMaurice
Copy link
Member

I believe these linting issues are false-positives as they're not coming from props.
What shall we do with this? @mhuggins wait for an update or ignore the rules on these lines?

@DalderupMaurice DalderupMaurice added the PR: don't merge This doesn't seem right label Dec 31, 2018
@mhuggins
Copy link
Contributor

mhuggins commented Jan 6, 2019

Yup, looks like a bug in the new version. It's looking at state and refs, treating them as props.

@DalderupMaurice
Copy link
Member

There's a false-positive fix pushed to v7.12.1 - I think that should resolve it. We'll see it tomorrow when renovate bot runs

@renovate renovate bot removed the rebase label Jan 7, 2019
@renovate renovate bot force-pushed the renovate/lint branch 2 times, most recently from 36865af to f7add3a Compare January 7, 2019 07:52
@renovate
Copy link
Contributor Author

renovate bot commented Jan 7, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #804 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #804   +/-   ##
========================================
  Coverage    54.17%   54.17%           
========================================
  Files          225      225           
  Lines         1914     1914           
  Branches       264      264           
========================================
  Hits          1037     1037           
  Misses         725      725           
  Partials       152      152

@DalderupMaurice DalderupMaurice merged commit afe68fa into develop Jan 7, 2019
@DalderupMaurice DalderupMaurice removed the PR: don't merge This doesn't seem right label Jan 7, 2019
@renovate renovate bot deleted the renovate/lint branch January 7, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Renovate 🌴 Dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants