Add a fix for nose2's own subprocess tests (on top of #601) #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nose2's testsuite does not really create subprocesses for most executions. This keeps things fast by doing all of the work in the current process, but is self-defeating when we really *do* want to isolate the work into a proper sub-execution and check the results, as is the case with `coverage` invocations (which involve coverage's own state on a per-interpreter basis). To resolve, add a helper for doing true subprocess invocations where appropriate, and use it to fix the broken coverage tests. A few minor edits were also needed to get this all working: - fix some subproc invocations using `target=...` - remove strange code from the "coverage of imports" scenario [^1] [^1]: I was the author of said scenario, many years ago. The commit history doesn't show it, but my suspicion is that with the test skipped, it was just a save of whatever my work in progress was, as I tried to get the test working at the time. It's hard to be certain, but the code in that file doesn't have a clearly credible reason to exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked up #601 and it looks good with some very minor tweaking to the tests (to fix
Processinstantiation).I then poked around at fixing the mysterious issues with coverage, and cooked up this fix after looking closely at the "NotReallyAProc" trickery which is used inside of the testsuite. My understanding of it is that it's a speed boost for the tests (especially Windows, where subprocess invocation is super slow). But if it makes tests fail, it's not doing any good. Slow and correct is much better than fast and wrong.