Skip to content

Commit

Permalink
test: move tests with many workers to sequential
Browse files Browse the repository at this point in the history
These tests spawn many workers, which may be CPU intensive causing
timeouts (see the referenced PR for more details). Let's move them
to sequential.

Refs: nodejs/node#44090
PR-URL: nodejs/node#44139
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
kvakil authored and guangwong committed Jan 3, 2023
1 parent 98ca2cb commit 1005479
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 1 deletion.
Expand Up @@ -5,7 +5,7 @@ if (!common.hasCrypto)
const assert = require('assert');
const http2 = require('http2');
const makeDuplexPair = require('../common/duplexpair');
const { Worker, parentPort } = require('worker_threads');
const { parentPort, Worker } = require('worker_threads');

// This test ensures that workers can be terminated without error while
// stream activity is ongoing, in particular the C++ function
Expand Down

0 comments on commit 1005479

Please sign in to comment.