Skip to content

Commit

Permalink
tools: increase timeout of running WPT
Browse files Browse the repository at this point in the history
We run all WPT from one subset in the same process using workers.
As the number of the tests grow, it can take longer to run some of the
subsets, but it's still overall faster than running them in different
processes. This patch increases the timeout
for WPT to prevent the test from failing because it takes longer
to run (even though it would still complete at some point).

Refs: nodejs/reliability#371
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs/node#44574
Backport-PR-URL: nodejs/node#44872
  • Loading branch information
joyeecheung authored and guangwong committed Jan 3, 2023
1 parent 7e8e093 commit bdc8758
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/test.py
Expand Up @@ -957,7 +957,7 @@ def GetVm(self, arch, mode):

def GetTimeout(self, mode, section=''):
timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode]
if section == 'pummel' or section == 'benchmark' or section == 'wpt':
if section == 'pummel' or section == 'benchmark':
timeout = timeout * 6
# We run all WPT from one subset in the same process using workers.
# As the number of the tests grow, it can take longer to run some of the
Expand Down

0 comments on commit bdc8758

Please sign in to comment.