Skip to content

Commit

Permalink
tty: fix TypeError when stream is closed
Browse files Browse the repository at this point in the history
Fixes: nodejs/node#41330
PR-URL: nodejs/node#43803
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
aduh95 authored and guangwong committed Jan 3, 2023
1 parent 10939d7 commit ec4c256
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/tty.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ ObjectSetPrototypeOf(ReadStream, net.Socket);

ReadStream.prototype.setRawMode = function(flag) {
flag = !!flag;
const err = this._handle.setRawMode(flag);
const err = this._handle?.setRawMode(flag);
if (err) {
this.emit('error', errors.errnoException(err, 'setRawMode'));
return this;
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-repl-stdin-push-null.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';
const common = require('../common');

if (!process.stdin.isTTY) {
common.skip('does not apply on non-TTY stdin');
}

process.stdin.destroy();
process.stdin.setRawMode(true);

0 comments on commit ec4c256

Please sign in to comment.