Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create videos nip #1241

Closed
wants to merge 2 commits into from
Closed

Create videos nip #1241

wants to merge 2 commits into from

Conversation

staab
Copy link
Member

@staab staab commented May 17, 2024

No description provided.

@staab staab requested a review from v0l May 17, 2024 15:33
@fiatjaf
Copy link
Member

fiatjaf commented May 17, 2024

This is 200x better than the other video NIP.

xx.md Show resolved Hide resolved
Copy link
Member

@v0l v0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but it kinda sucks that there are a bunch of people publishing videos on the other nip and all those will be abandoned.

There are over 750 when i checked

The following tags are optional:

- `i` is an external GUID in the format defined [here](https://github.com/MerryOscar/nips/commit/280eb498e0ac56b8f9356c1b7a88cc8b31579801).
- `c` is the video's value as defined by a given category.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a c tag? Never seen it used before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pulled from the audio NIP this was based on. It would be the equivalent to something like youtube's categories.


- `i` is an external GUID in the format defined [here](https://github.com/MerryOscar/nips/commit/280eb498e0ac56b8f9356c1b7a88cc8b31579801).
- `c` is the video's value as defined by a given category.
- `website` is an external url to a website related to the video.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you would need this, seems more likely its something you would link inside content

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, pulled from audio, based on use cases provided by wavlake and fountain. So it might not transfer over, but could be useful. I can simplify the NIP for the short term.

xx.md Outdated Show resolved Hide resolved
@staab
Copy link
Member Author

staab commented May 20, 2024

Looks ok, but it kinda sucks that there are a bunch of people publishing videos on the other nip and all those will be abandoned.

It does suck. I wouldn't propose this NIP if the other one had a story for associating multiple files with a single video. It seems like you'd want your download url to be different from your streaming url, at least that's how the stemstr guys did their audio stuff. But you'd know better than me, I haven't worked with streaming video at all. Am I seeing problems that don't exist?

@v0l
Copy link
Member

v0l commented May 20, 2024

I mean you could have just put more url tags with a marker, but imeta is better.

So in the case of videos with multiple resolutions you can have multiple imeta tags with the dim property set, which is something the other NIP didnt have.

I just deployed the NIP-71 styles videos to https://zap.stream/videos

@staab
Copy link
Member Author

staab commented May 20, 2024

Alright, your implementation is a stronger vote than my uneducated alternative NIP. Closing in favor of #923

@staab staab closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants