Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsevent should join on thread shutdown #337

Merged
merged 1 commit into from Jun 28, 2021
Merged

Commits on Jun 10, 2021

  1. fsevent should join on thread shutdown

    We had some test failures because crossbeam-channel may panic when trying
    to call recv() during thread shutdown. This seems to be similar to this
    upstream bug: crossbeam-rs/crossbeam#321.
    Unfortunately it seems that some operating systems may tear down thread-local
    storage early, rust-lang/rust#28129, which can
    trigger panics if trying to interact with TLS during a drop.
    
    To avoid this issue, this switches from using a channel to signal the thread
    shutdown to just using the join handle (which we should have been doing
    anyway).
    erickt committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    b7cbb00 View commit details
    Browse the repository at this point in the history