Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path information to inotify and kqueue watch/unwatch errors #354

Merged
merged 3 commits into from Aug 22, 2021
Merged

Add path information to inotify and kqueue watch/unwatch errors #354

merged 3 commits into from Aug 22, 2021

Conversation

passcod
Copy link
Member

@passcod passcod commented Aug 22, 2021

Fixes #353

@passcod passcod requested a review from 0xpr03 August 22, 2021 17:13
0xpr03
0xpr03 approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@0xpr03 0xpr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Do you want a new pre-release for that ?

@0xpr03 0xpr03 merged commit 23f54f6 into main Aug 22, 2021
@passcod
Copy link
Member Author

passcod commented Aug 22, 2021

It can go in the next one whenever, no urgency.

@passcod passcod deleted the pr/error-paths branch August 22, 2021 18:16
@0xpr03
Copy link
Member

0xpr03 commented Sep 10, 2021

FYI: published as 5.0.0-pre.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xpr03 0xpr03 0xpr03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report which sub-path failed when adding a Recursive watch and a subfolder has a permission (or other) error
2 participants
@passcod @0xpr03