fsevent: return error on canonicalize failure #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a panic that can occur in `append_path` when a file is removed after passing the `exists` check, but before canonicalization. This change moves `canonicalize` before appending the path, so that it can safely bail on error without leaking state.
JohnTitor
approved these changes
Nov 20, 2021
0xpr03
reviewed
Nov 21, 2021
0xpr03
requested changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a panic that can occur in
append_pathwhen a file is removedafter passing the
existscheck, but before canonicalization. Thischange moves
canonicalizebefore appending the path, so that it cansafely bail on error without leaking state.
Fixes #368.