Kqueue emit Create Events and watch all files in a directory #372
+65
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kqueue backend started as a copy of the inotify backend. One major difference between kqueue and inotify was overlook by me, inotify reports events for changes to files contained in a folder if the folder is watched. Kqueue dosen't do this, each file has to be watch individually. This change fixes this, events are now reported for all files in a recursive watch.
0xpr03
requested changes
Dec 7, 2021
0xpr03
approved these changes
Dec 13, 2021
|
Sadly the CI isn't happy https://github.com/notify-rs/notify/runs/4487903445?check_suite_focus=true |
As kqueue dosen't provide this information directly we have to do some trickery, that is keep a list of known file in a directory and compare it to the directory after a Write event was emitted for that directory. This change fixes #365.
|
That issue should be fixed now, totally missed it. A simple |
|
@0xpr03 is there anything preventing this from getting merged? |
|
Sorry it's just on me to find the time |
0xpr03
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some shortcoming in the kqueue backend.
The kqueue backend started as a copy of the inotify backend.
One major difference between kqueue and inotify was overlook by me,
inotify reports events for changes to files contained in a folder if the
folder is watched. Kqueue dosen't do this, each file has to be watch
individually.
As kqueue dosen't provide this information directly we have to do some
trickery, that is keep a list of known file in a directory and compare
it to the directory after a Write event was emitted for that directory.
This fixes #365