Clean-up CI config #417
Merged
Clean-up CI config #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
0xpr03
reviewed
Jun 16, 2022
| @@ -523,7 +525,7 @@ impl PollWatcher { | |||
| .unwrap() | |||
| .remove(path) | |||
| .map(|_| ()) | |||
| .ok_or_else(|| crate::Error::watch_not_found()) | |||
| .ok_or_else(crate::Error::watch_not_found) | |||
There was a problem hiding this comment.
hm yeah should've watched out for that, probably let clippy do its thing
JohnTitor
commented
Jun 16, 2022
| @@ -61,7 +72,6 @@ jobs: | |||
| target: | |||
| - x86_64-unknown-netbsd | |||
| - x86_64-unknown-freebsd | |||
| - x86_64-apple-darwin | |||
There was a problem hiding this comment.
@0xpr03 Removed x86_64-apple-darwin as we've already tested code with macOS on the above ci workflow. I think it should be fine but would like to mention it, just in case.
|
Thanks, that'll make the CI usable again for other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.