feat: enforce pnpm 7.5.0 #1125

venarius · 2022-08-25T13:05:35Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This fixes some issues with pnpm that I had while creating PRs for Novu:

1. Newer versions of pnpm will break the CI and seem to install unneeded packages.

Reference: refactor: use date-fns instead of moment #1122

Solution: Enforce pnpm version of 7.5.0

2. When running npm run setup:project for the first time everything works as inteded. But if you run that command again it would downgrade your pnpm-lock.yaml to lockfileVersion 5.3

Reference inside feat: enable custom theme to be provided to iframe embed #1048:

That was an issue because of the repos package.json having pnpm: 6.34.0 as devDependency and npx falling back to the local cached version instead of using the version number provided in the cli command:

Solution: Increase the devDependency version of pnpm to 7.5.0

vercel · 2022-08-25T13:05:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
docs	✅ Ready (Inspect)	Visit Preview	Aug 28, 2022 at 1:09PM (UTC)

netlify · 2022-08-25T13:05:47Z

✅ Deploy Preview for docs-novu canceled.

Name	Link
🔨 Latest commit	`63f383c`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-novu/deploys/630b684da72cff0008bbfb76

venarius · 2022-08-25T13:29:43Z

Reason for failing NX build command: nrwl/nx#10111
Due to upgrade of pnpm from 6.34.0 to 7.5.0 as devDependency. Issue fixed with NX version 14.5.10. Because of that I also upgraded NX from 14.5.4 to 14.5.10

scopsy

This is great, a small comment on the setup:project command wdyt on that one?

scopsy · 2022-08-25T19:57:39Z

package.json

  "scripts": {
    "bootstrap": "npm run setup:dev",
    "start": "npm run jarvis",
    "preinstall": "npx only-allow pnpm",
    "prepare": "husky install",
    "publish": "lerna publish from-package",
-    "setup:project": "npx pnpm@7.5.0 i && node scripts/setup-env-files.js && npx pnpm build",
+    "setup:project": "pnpm i && node scripts/setup-env-files.js && pnpm build",


Suggested change

"setup:project": "pnpm i && node scripts/setup-env-files.js && pnpm build",

"setup:project": "npx pnpm i && node scripts/setup-env-files.js && npm run build",

Wanted to have the initial setup of the project work without pnpm installed on your machine, and you would need it only if you want to add some dependencies. Wdyt, of only leaving the npx here?

Yeah we can do that, true 🙂 But we still need to lock the version number then because it will otherwise install the latest pnpm and we can leave pnpm in the end because it is installed after running the pnpm i - I commited it

good point about the lock part. Agree with this.

scopsy · 2022-08-25T19:57:47Z

package.json

@@ -111,7 +112,7 @@
    "listr": "^0.14.3",
    "meow": "^10.1.1",
    "mississippi": "^4.0.0",
-    "pnpm": "^6.34.0",
+    "pnpm": "7.5.0",


This is great!

scopsy · 2022-08-25T19:58:07Z

package.json

@@ -1,13 +1,14 @@
 {
  "name": "novuhq",
  "private": true,
+  "packageManager": "pnpm@7.5.0",


Oh nice didn't knew this prop existed

scopsy · 2022-08-28T10:14:33Z

Oh Looks like vercel is failing :|





Cloning github.com/novuhq/novu (Branch: feat/enforce-pnpm-version, Commit: 310dec1)
23:36:18.232 | Cloning completed: 738.862ms
23:36:19.463 | Looking up build cache...
23:36:23.267 | Build cache downloaded [53.70 MB]: 3123.984ms
23:36:23.489 | Running "vercel build"
23:36:23.984 | Vercel CLI 28.1.2
23:36:24.537 | Detected `pnpm-lock.yaml` generated by pnpm 7...
23:36:24.537 | Running "install" command: `cd ../ && npm run install:docs`...
23:36:24.753 |  
23:36:24.754 | > novuhq@ install:docs /vercel/path0
23:36:24.754 | > pnpm install --filter @novu/docs
23:36:24.754 |  
23:36:25.319 | ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)
23:36:25.319 |  
23:36:25.320 | Your pnpm version is incompatible with "/vercel/path0".
23:36:25.320

We are looking right now to switch to netlify and they allow easily override the install script on their dashboard.

scopsy · 2022-08-28T10:17:07Z

@andrewgolovanov this one is another reason we want to make the move to netlify for all our projects.

venarius · 2022-08-28T11:25:27Z

@scopsy maybe you can use this? https://vercel.com/changelog/corepack-experimental-is-now-available - thats why I added that packageManager field

scopsy · 2022-08-28T12:51:35Z

It worked!

vercel · 2022-08-28T13:06:25Z

@scopsy is attempting to deploy a commit to the Novu Team on Vercel.

A member of the Team first needs to authorize it.

vercel bot had a problem deploying to Preview August 25, 2022 13:05 Failure

feat: enforce pnpm 7.5.0

d98473b

vercel bot had a problem deploying to Preview August 25, 2022 13:11 Failure

fix: fix failing nx build command

48189b9

vercel bot had a problem deploying to Preview August 25, 2022 13:27 Failure

Merge branch 'main' into feat/enforce-pnpm-version

765517a

vercel bot had a problem deploying to Preview August 25, 2022 19:54 Failure

scopsy reviewed Aug 25, 2022

View reviewed changes

fix: add npx for setup:project script

310dec1

vercel bot deployed to Preview August 25, 2022 20:36 View deployment

Merge branch 'main' into pr/1125

63f383c

vercel bot deployed to Preview August 28, 2022 13:09 View deployment

scopsy approved these changes Aug 29, 2022

View reviewed changes

scopsy merged commit 38467f3 into novuhq:main Aug 29, 2022

venarius deleted the feat/enforce-pnpm-version branch August 29, 2022 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enforce pnpm 7.5.0 #1125

feat: enforce pnpm 7.5.0 #1125

venarius commented Aug 25, 2022

vercel bot commented Aug 25, 2022 •

edited

netlify bot commented Aug 25, 2022 •

edited

venarius commented Aug 25, 2022 •

edited

scopsy left a comment

scopsy Aug 25, 2022

venarius Aug 25, 2022 •

edited

scopsy Aug 28, 2022

scopsy Aug 25, 2022

scopsy Aug 25, 2022

scopsy commented Aug 28, 2022

scopsy commented Aug 28, 2022

venarius commented Aug 28, 2022 •

edited

scopsy commented Aug 28, 2022

vercel bot commented Aug 28, 2022

	"setup:project": "pnpm i && node scripts/setup-env-files.js && pnpm build",
	"setup:project": "npx pnpm i && node scripts/setup-env-files.js && npm run build",

feat: enforce pnpm 7.5.0 #1125

feat: enforce pnpm 7.5.0 #1125

Conversation

venarius commented Aug 25, 2022

1. Newer versions of pnpm will break the CI and seem to install unneeded packages.

2. When running npm run setup:project for the first time everything works as inteded. But if you run that command again it would downgrade your pnpm-lock.yaml to lockfileVersion 5.3

vercel bot commented Aug 25, 2022 • edited

netlify bot commented Aug 25, 2022 • edited

✅ Deploy Preview for docs-novu canceled.

venarius commented Aug 25, 2022 • edited

scopsy left a comment

Choose a reason for hiding this comment

scopsy Aug 25, 2022

Choose a reason for hiding this comment

venarius Aug 25, 2022 • edited

Choose a reason for hiding this comment

scopsy Aug 28, 2022

Choose a reason for hiding this comment

scopsy Aug 25, 2022

Choose a reason for hiding this comment

scopsy Aug 25, 2022

Choose a reason for hiding this comment

scopsy commented Aug 28, 2022

scopsy commented Aug 28, 2022

venarius commented Aug 28, 2022 • edited

scopsy commented Aug 28, 2022

vercel bot commented Aug 28, 2022

2. When running `npm run setup:project` for the first time everything works as inteded. But if you run that command again it would downgrade your pnpm-lock.yaml to lockfileVersion 5.3

vercel bot commented Aug 25, 2022 •

edited

netlify bot commented Aug 25, 2022 •

edited

venarius commented Aug 25, 2022 •

edited

venarius Aug 25, 2022 •

edited

venarius commented Aug 28, 2022 •

edited