fix: falsey default values not included (#219)

* fix: falsey default values not included fixes issue where a defined but falsey default value is not included in inputs table * test: falsey default values not included
npalm · May 24, 2022 · 7dc133b · 7dc133b
1 parent e7cb32d
commit 7dc133b
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 3 deletions.
diff --git a/__tests__/fixtures/all_fields_action.output b/__tests__/fixtures/all_fields_action.output
@@ -10,6 +10,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 ## Outputs

diff --git a/__tests__/fixtures/all_fields_action.yml b/__tests__/fixtures/all_fields_action.yml
@@ -16,6 +16,10 @@ inputs:
     description: 'A description D'
     required: false
     default: D
+  inputE:
+    description: 'A description E'
+    required: false
+    default: false
 
 outputs:
   outputA:
@@ -25,4 +29,4 @@ outputs:
 
 runs:
   using: 'node12'
-  main: 'dist/index.js'
+  main: 'dist/index.js'
diff --git a/__tests__/fixtures/all_fields_action.yml.crlf b/__tests__/fixtures/all_fields_action.yml.crlf
@@ -16,6 +16,10 @@ inputs:
     description: 'A description D'
     required: false
     default: D
+  inputE:
+    description: 'A description E'
+    required: false
+    default: false
 
 outputs:
   outputA:
@@ -25,4 +29,4 @@ outputs:
 
 runs:
   using: 'node12'
-  main: 'dist/index.js'
+  main: 'dist/index.js'
diff --git a/__tests__/fixtures/all_fields_action_toc1.output b/__tests__/fixtures/all_fields_action_toc1.output
@@ -10,6 +10,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 # Outputs

diff --git a/__tests__/fixtures/all_fields_action_toc3_cli.output b/__tests__/fixtures/all_fields_action_toc3_cli.output
@@ -10,6 +10,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 ### Outputs

diff --git a/__tests__/fixtures/all_fields_readme.output b/__tests__/fixtures/all_fields_readme.output
@@ -15,6 +15,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 

diff --git a/__tests__/fixtures/all_fields_readme.output.crlf b/__tests__/fixtures/all_fields_readme.output.crlf
@@ -15,6 +15,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 

diff --git a/__tests__/fixtures/all_fields_readme_filled.input b/__tests__/fixtures/all_fields_readme_filled.input
@@ -14,6 +14,7 @@ Default test abc
 | inputA | A description A | `false` |  |
 | inputB | A description B | `true` |  |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 

diff --git a/__tests__/fixtures/all_fields_readme_filled.output b/__tests__/fixtures/all_fields_readme_filled.output
@@ -15,6 +15,7 @@ Default test
 | inputB | A description B | `true` |  |
 | inputC | A description C | `true` | C |
 | inputD | A description D | `false` | D |
+| inputE | A description E | `false` | false |
 
 
 

diff --git a/src/action-docs.ts b/src/action-docs.ts
@@ -189,7 +189,7 @@ function getInputOutput(
       rows[i].push(
         value.required ? `\`${String(value.required)}\`` : "`false`"
       );
-      rows[i].push(value.default ? value.default : "");
+      rows[i].push(value.default !== undefined ? value.default : "");
     }
   }
   return { headers, rows };