This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: deps of linked deps in package-lock #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaacs fixup commit fixes snapshots in a few load-actual and shrinkwrap tests which pruned some I assume these now missing lines are due to Would be good to double check that it all makes sense 👍 |
isaacs
reviewed
Feb 12, 2021
| @@ -11,7 +11,7 @@ const calcDepFlags = (tree, resetRoot = true) => { | |||
| tree, | |||
| visit: node => calcDepFlagsStep(node), | |||
| filter: node => node, | |||
| getChildren: node => [...node.edgesOut.values()].map(edge => edge.to), | |||
| getChildren: (node, tree) => [...tree.edgesOut.values()].map(edge => edge.to), | |||
There was a problem hiding this comment.
This is the optimally unconfusing way to do it, but it tickles me that the whole diff could've been:
- getChildren: node => ....
+ getChildren: (_,node) => ....
When having optional dependencies of a dependency of
a top-level link dependency, e.g:
root -> LINK(a)
a -> (b)
b -> OPTIONAL(c)
* c marked as extraneous
Any optional dependency (and all its nested nodes) were marked
as extraneous in package-lock due to `calcDepFlags` missing
properly following the target of Link nodes.
This changeset fixes it by properly following the result of the
`treeverse.visit` method that will have already followed any
link targets at that point.
Fixes: npm/cli#2505
PR-URL: npm#229
Credit: @ruyadorno
Close: npm#229
Reviewed-by: @isaacs
isaacs
force-pushed
the
fix-package-lock-optional-deps-of-linked-deps
branch
from
1f4f74d
to
c2666af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having optional dependencies of a dependency of
a top-level link dependency, e.g:
Any optional dependency (and all its nested nodes) were marked
as extraneous in package-lock due to
calcDepFlagsmissingproperly following the target of Link nodes.
This changeset fixes it by properly following the result of the
treeverse.visitmethod that will have already followed anylink targets at that point.
Fixes: npm/cli#2505
References