Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

skip optional deps with mismatched platform #231

Merged
merged 3 commits into from Feb 18, 2021
Merged

skip optional deps with mismatched platform #231

merged 3 commits into from Feb 18, 2021

Commits on Feb 18, 2021

  1. expand the platform-specifying-test-package fixture so it has a tarba… 

    …ll and uses a completely invalid os

also added an actual assertion to a build-ideal-tree test, and removed a test skip that we no longer need
    @nlf @isaacs
    nlf authored and isaacs committed Feb 18, 2021
    Copy the full SHA
    894fbef View commit details
    Browse the repository at this point in the history

  2. add notes about new optional dependency behavior

    @nlf @isaacs
    nlf authored and isaacs committed Feb 18, 2021
    Copy the full SHA
    a98d6fd View commit details
    Browse the repository at this point in the history

  3. fix: skip optional deps with mismatched platform or engine 

    PR-URL: #231
Credit: @nlf
Close: #231
Reviewed-by: @isaacs
    @nlf @isaacs
    nlf authored and isaacs committed Feb 18, 2021
    Copy the full SHA
    4a3322d View commit details
    Browse the repository at this point in the history