fix: file moving on Android #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wraithgar it's been a while since this has been open, can you please take a look? |
VoltrexKeyva
changed the title
|
@lukekarrys can you also please take a look? Note that the tests fail on pretty much every PR that has code changes because the coverage threshold is set to a seemingly unreasonable goal of 100%, what is the reason for this? |
The `moveFile()` function tries to make a hard link which isn't supported on Android, which results in a `EACCES` error, so call `move()` directly when running on Android. Fixes #155
|
We're just gonna not do any of this anymore #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
moveFile()function tries to make a hard link which isn't supported on Android, which results in aEACCESerror, so callmove()directly when running on Android.References
Fixes #155