fix: add two tests

npm · Jan 8, 2024 · 1d965ae · 1d965ae
1 parent 909cfab
commit 1d965ae
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 2 deletions.
diff --git a/lib/commands/install.js b/lib/commands/install.js
@@ -148,10 +148,10 @@ class Install extends ArboristWorkspaceCmd {
       const isJsonEmptyObject = Object.keys(jsonContent).length === 0
         && jsonContent.constructor === Object
 
-      const emptyJson = new Error()
+      const emptyJson = new Error('EEMPTYPKGJSON: package.json is empty object')
       emptyJson.code = 'EEMPTYPKGJSON'
       emptyJson.path = pkgJson.filename
-      if(isJsonEmptyObject) {
+      if (isJsonEmptyObject) {
         throw emptyJson
       }
     }

diff --git a/test/lib/commands/install.js b/test/lib/commands/install.js
@@ -1,5 +1,7 @@
 const t = require('tap')
 const { load: loadMockNpm } = require('../../fixtures/mock-npm')
+const fs = require('node:fs')
+const path = require('node:path')
 
 t.test('exec commands', async t => {
   await t.test('with args, dev=true', async t => {
@@ -9,6 +11,9 @@ t.test('exec commands', async t => {
     let ARB_OBJ = null
 
     const { npm } = await loadMockNpm(t, {
+      prefixDir: {
+        'package.json': '{ "name": "does not matter" }',
+      },
       mocks: {
         '@npmcli/run-script': ({ event }) => {
           SCRIPTS.push(event)
@@ -53,6 +58,9 @@ t.test('exec commands', async t => {
     let ARB_OBJ = null
 
     const { npm } = await loadMockNpm(t, {
+      prefixDir: {
+        'package.json': '{ "name": "does not matter" }',
+      },
       mocks: {
         '@npmcli/run-script': ({ event }) => {
           SCRIPTS.push(event)
@@ -93,6 +101,9 @@ t.test('exec commands', async t => {
     const SCRIPTS = []
     let REIFY_CALLED = false
     const { npm } = await loadMockNpm(t, {
+      prefixDir: {
+        'package.json': '{ "name": "does not matter" }',
+      },
       mocks: {
         '{LIB}/utils/reify-finish.js': async () => {},
         '@npmcli/run-script': ({ event }) => {
@@ -165,6 +176,37 @@ t.test('exec commands', async t => {
     )
   })
 
+  await t.test('should throw when package.json does not exist', async t => {
+    const { npm, prefix } = await loadMockNpm(t, {})
+    await t.rejects(
+      npm.exec('install'),
+      /ENOENT: no such file or directory/,
+      'should throw before reify'
+    )
+    t.notOk(
+      fs.existsSync(path.join(prefix, './package-lock.json')),
+      'should not generate package-lock.json'
+    )
+  })
+
+  await t.test('should throw when package.json is an empty object', async t => {
+    const { npm, prefix } = await loadMockNpm(t, {
+      prefixDir: {
+        'package.json': '{}',
+      },
+    })
+    await t.rejects(
+      npm.exec('install'),
+      /EEMPTYPKGJSON: package.json is empty object/,
+      'should throw before reify'
+    )
+
+    t.notOk(
+      fs.existsSync(path.join(prefix, './package-lock.json')),
+      'should not generate package-lock.json'
+    )
+  })
+
   await t.test('npm i -g npm engines check success', async t => {
     const { npm } = await loadMockNpm(t, {
       mocks: {