fix(view): fix non-registry specs

This was working by coincidence in 7.7.6 and before, and broken in the 7.8.0 refactor. Before, it would see there was no "name" in the spec, and then read your local package.json, and from that get a `latest` tag. So, if you didn't have a package.json in your CWD it would fail with an ENOENT trying to read it. This fixes it for real, so that if you aren't asking for info from a registry spec, it goes ahead and looks for the `latest` tag (or whatever tag you have configured as your default).
npm · May 7, 2021 · 291ab47 · 291ab47
1 parent 049166b
commit 291ab47
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 16 deletions.
diff --git a/lib/view.js b/lib/view.js
@@ -202,7 +202,10 @@ class View extends BaseCommand {
     const spec = npa(pkg)
 
     // get the data about this package
-    let version = spec.rawSpec || this.npm.config.get('tag')
+    let version = this.npm.config.get('tag')
+    // rawSpec is the git url if this is from git
+    if (spec.type !== 'git' && spec.rawSpec)
+      version = spec.rawSpec
 
     const pckmnt = await packument(spec, opts)
 

diff --git a/tap-snapshots/test/lib/view.js.test.cjs b/tap-snapshots/test/lib/view.js.test.cjs
@@ -80,7 +80,7 @@ dist
 .unpackedSize:[33m1[39m B
 
 dist-tags:
-
+[1m[32mlatest[39m[22m: 1.0.0
 
 published [33ma year ago[39m
 `
@@ -97,7 +97,7 @@ dist
 .unpackedSize:[33m1[39m B
 
 dist-tags:
-
+[1m[32mlatest[39m[22m: 1.0.0
 
 published [33ma year ago[39m
 `
@@ -108,7 +108,9 @@ exports[`test/lib/view.js TAP should log package info package with --json and se
   {
     "_npmUser": "claudia <claudia@cyan.com>",
     "name": "cyan",
-    "dist-tags": {},
+    "dist-tags": {
+      "latest": "1.0.0"
+    },
     "versions": [
       "1.0.0",
       "1.0.1"
@@ -125,7 +127,9 @@ exports[`test/lib/view.js TAP should log package info package with --json and se
   {
     "_npmUser": "claudia <claudia@cyan.com>",
     "name": "cyan",
-    "dist-tags": {},
+    "dist-tags": {
+      "latest": "1.0.0"
+    },
     "versions": [
       "1.0.0",
       "1.0.1"
@@ -249,7 +253,7 @@ dist
 .unpackedSize:[33m1[39m B
 
 dist-tags:
-
+[1m[32mlatest[39m[22m: 1.0.0
 
 published by [33mclaudia[39m <[36mclaudia@cyan.com[39m>
 `
@@ -266,7 +270,7 @@ dist
 .unpackedSize:[33m1[39m B
 
 dist-tags:
-
+[1m[32mlatest[39m[22m: 1.0.0
 
 published [33ma year ago[39m
 `

diff --git a/test/lib/view.js b/test/lib/view.js
@@ -34,7 +34,9 @@ const packument = (nv, opts) => {
     },
     blue: {
       name: 'blue',
-      'dist-tags': {},
+      'dist-tags': {
+        latest: '1.0.0',
+      },
       time: {
         '1.0.0': '2019-08-06T16:21:09.842Z',
       },
@@ -59,7 +61,9 @@ const packument = (nv, opts) => {
         email: 'claudia@cyan.com',
       },
       name: 'cyan',
-      'dist-tags': {},
+      'dist-tags': {
+        latest: '1.0.0',
+      },
       versions: {
         '1.0.0': {
           version: '1.0.0',
@@ -248,7 +252,10 @@ t.test('should log package info', t => {
     },
   })
   const npm = mockNpm({
-    config: { global: false },
+    config: {
+      global: false,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
 
@@ -258,7 +265,10 @@ t.test('should log package info', t => {
     },
   })
   const jsonNpm = mockNpm({
-    config: { json: true },
+    config: {
+      json: true,
+      tag: 'latest',
+    },
   })
   const viewJson = new ViewJson(jsonNpm)
 
@@ -269,6 +279,7 @@ t.test('should log package info', t => {
   })
   const unicodeNpm = mockNpm({
     config: {
+      tag: 'latest',
       global: false,
       unicode: true,
     },
@@ -388,6 +399,7 @@ t.test('should log info by field name', t => {
   })
   const jsonNpm = mockNpm({
     config: {
+      tag: 'latest',
       json: true,
       global: false,
     },
@@ -401,7 +413,10 @@ t.test('should log info by field name', t => {
     },
   })
   const npm = mockNpm({
-    config: { global: false },
+    config: {
+      global: false,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
 
@@ -474,7 +489,10 @@ t.test('should log info by field name', t => {
 t.test('throw error if global mode', (t) => {
   const View = t.mock('../../lib/view.js')
   const npm = mockNpm({
-    config: { global: true },
+    config: {
+      global: true,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
   view.exec([], (err) => {
@@ -489,7 +507,10 @@ t.test('throw ENOENT error if package.json misisng', (t) => {
   const View = t.mock('../../lib/view.js')
   const npm = mockNpm({
     prefix: testDir,
-    config: { global: false },
+    config: {
+      global: false,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
   view.exec([], (err) => {
@@ -506,7 +527,10 @@ t.test('throw EJSONPARSE error if package.json not json', (t) => {
   const View = t.mock('../../lib/view.js')
   const npm = mockNpm({
     prefix: testDir,
-    config: { global: false },
+    config: {
+      global: false,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
   view.exec([], (err) => {
@@ -523,7 +547,10 @@ t.test('throw error if package.json has no name', (t) => {
   const View = t.mock('../../lib/view.js')
   const npm = mockNpm({
     prefix: testDir,
-    config: { global: false },
+    config: {
+      global: false,
+      tag: 'latest',
+    },
   })
   const view = new View(npm)
   view.exec([], (err) => {