fix(config): tie save-exact/save-prefix together

Each affects the other
npm · Mar 25, 2021 · 5ecaf92 · 5ecaf92
1 parent 2b3d1f9
commit 5ecaf92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/lib/utils/config/definitions.js b/lib/utils/config/definitions.js
@@ -1526,7 +1526,11 @@ define('save-exact', {
     Dependencies saved to package.json will be configured with an exact
     version rather than using npm's default semver range operator.
   `,
-  flatten,
+  flatten (key, obj, flatOptions) {
+    flatOptions.saveExact = obj['save-exact']
+    flatOptions.savePrefix = obj['save-exact'] ? '' : obj['save-prefix']
+    obj['save-prefix'] = flatOptions.savePrefix
+  },
 })
 
 define('save-optional', {
@@ -1594,7 +1598,8 @@ define('save-prefix', {
     only allows patch upgrades.
   `,
   flatten (key, obj, flatOptions) {
-    flatOptions.savePrefix = obj['save-exact'] ? '' : obj['save-prefix']
+    // just call the save-exact flattener, it reads from obj['save-prefix']
+    definitions['save-exact'].flatten('save-exact', obj, flatOptions)
   },
 })
 

diff --git a/test/lib/utils/config/definitions.js b/test/lib/utils/config/definitions.js
@@ -748,9 +748,9 @@ t.test('save-prefix', t => {
   const flat = {}
   definitions['save-prefix']
     .flatten('save-prefix', { ...obj, 'save-exact': true }, flat)
-  t.strictSame(flat, { savePrefix: '' })
+  t.strictSame(flat, { saveExact: true, savePrefix: '' })
   definitions['save-prefix']
     .flatten('save-prefix', { ...obj, 'save-exact': false }, flat)
-  t.strictSame(flat, { savePrefix: '~1.2.3' })
+  t.strictSame(flat, { saveExact: false, savePrefix: '~1.2.3' })
   t.end()
 })