refactor: change flow of otplease

npm · Jun 29, 2022 · d0af95f · d0af95f
1 parent 0ce09f1
commit d0af95f
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/lib/utils/otplease.js b/lib/utils/otplease.js
@@ -2,15 +2,20 @@ async function otplease (opts, fn) {
   try {
     return await fn(opts)
   } catch (err) {
-    const readUserInfo = require('./read-user-info.js')
-    if (err.code !== 'EOTP' && (err.code !== 'E401' || !/one-time pass/.test(err.body))) {
+    if (!process.stdin.isTTY || !process.stdout.isTTY) {
       throw err
-    } else if (!process.stdin.isTTY || !process.stdout.isTTY) {
-      throw err
-    } else {
+    }
+
+    const isBackwardsCompatibleOTP = err.code === 'E401' && /one-time pass/.test(err.body)
+    const isClassicOTP = err.code === 'EOTP'
+
+    if (isClassicOTP || isBackwardsCompatibleOTP) {
+      const readUserInfo = require('./read-user-info.js')
       const otp = await readUserInfo.otp('This operation requires a one-time password.\nEnter OTP:')
       return await fn({ ...opts, otp })
     }
+
+    throw err
   }
 }