fix(docs): add missing note #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
semver:patch
|
Can this be reworded a little? It's not clear what is being communicated by the addition? Perhaps something like "commands will be run in each workspace in the order they appear in your package.json"? |
|
@wraithgar Sure |
lukekarrys
requested changes
Sep 29, 2021
There was a problem hiding this comment.
I agree with @wraithgar's comment that this should be reworded a little.
|
@wraithgar @lukekarrys Done |
behnammodi
force-pushed
the
latest
branch
2 times, most recently
from
8bf2985
to
08400d0
Compare
wraithgar
approved these changes
Sep 29, 2021
lukekarrys
approved these changes
Sep 29, 2021
|
@behnammodi can you resolve the conflicts this has against |
|
Sorry about that, this file usually doesn't get a lot of activity but it just so happened to get conflicting updates in the last two weeks. |
|
@wraithgar no problem, sure, I'll do it |
|
@wraithgar Done |
PR-URL: npm#3699 Credit: @behnammodi Close: npm#3699 Reviewed-by: @wraithgar
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing note