Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.24.2 #3831

Merged
merged 16 commits into from Oct 4, 2021
Merged

v7.24.2 #3831

merged 16 commits into from Oct 4, 2021

Conversation

lukekarrys
Copy link
Member

v7.24.2 (2021-10-04)

BUG FIXES

DEPENDENCIES

  • 69ab10bbf is-core-module@2.7.0
  • e94ddeaca @npmcli/arborist@2.9.0:
    • fix: avoid infinite loops in peer dep replacements
    • fix: use Intl.Collator for string sorting when available
    • feat(vuln): expose isDirect

DOCUMENTATION

wraithgar and others added 16 commits September 27, 2021 09:31
will filter out a small subset of non-URL-safe characters that still
parse properly with `new URL`

PR-URL: #3804
Credit: @isaacs
Close: #3804
Reviewed-by: @wraithgar
closes: #2556
xref: #1750

The xref'ed PR apparently dropped this behavior
without any explanation.

PR-URL: #3799
Credit: @gfyoung
Close: #3799
Reviewed-by: @wraithgar
  * fix: avoid infinite loops in peer dep replacements
  * fix: use Intl.Collator for string sorting when available
  * feat(vuln): expose isDirect
The npm/cli form of npm/arborist#324

Required adding options support to package used for this.

PR-URL: #3809
Credit: @isaacs
Close: #3809
Reviewed-by: @wraithgar
  * includeWorkspaceRoot support
  * workspacesEnabled=false support

PR-URL: #3815
Credit: @wraithgar
Close: #3815
Reviewed-by: @isaacs
Adds a new config item that includes the workspace root when running
non-arborist commands (i.e. repo, version, publish).  Arborist will need
to be udpated to look for this flag to change its behavior to include
the workspace root for its functions.

This also changes --workspaces to a trinary, so that setting it to false
will explicitly exclude workspaces altogether.  This is also going to
require an arborist change so that it ignores workspaces altogether.

Co-author: @fritzy

PR-URL: #3816
Credit: @isaacs
Close: #3816
Reviewed-by: @wraithgar
This reverts commit 8349c3c.

PR-URL: #3817
Credit: @lukekarrys
Close: #3817
Reviewed-by: @wraithgar
@lukekarrys lukekarrys requested a review from a team as a code owner October 4, 2021 16:57
@lukekarrys lukekarrys merged commit 04eb43f into latest Oct 4, 2021
Copy link

@boostvolt boostvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the exit code is related to the following #1109 and ongoing issues. With the changes in the 075fe50 #3799 PR, the npm outdated --json command can no longer be executed correctly under all conditions.

@wraithgar
Copy link
Member

The removal of the exit code is related to the following #1109 and ongoing issues. With the changes in this PR, the npm outdated --json command can no longer be executed correctly under all conditions.

You're right, we missed that when we reintroduced this #3799. It was even discussed how we didn't need the if statement, and the json case wasn't considered.

@wraithgar
Copy link
Member

#3844

@nlf nlf deleted the release/v7.24.2 branch March 28, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants