Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix escaping breaking out over line wrap #104

Closed
wants to merge 1 commit into from
Closed

fix escaping breaking out over line wrap #104

wants to merge 1 commit into from

Conversation

KyleMit
Copy link

@KyleMit KyleMit commented Nov 27, 2018

Here's what the markdown is supposed to look like:

image

But here's what the same section looks like on the live docs site:

image

If we look at the markdown source, we can see the inline code block is opened on line 55 and then the text is automatically wrapped to fit into 80 character column width.

image

Which means whatever is converting the markdown to markup is not escaping the <pkg> tag on line 56 and opens up a tag that is never closed. Here's proof via inspect element on the live docs page:

image

Whatever script automatically wrapped at 80 chars may have caused other issues as well that only show up depending on the engine rendering the markdown

@KyleMit KyleMit requested a review from a team as a code owner November 27, 2018 00:59
@Alhadis
Copy link

Alhadis commented Dec 2, 2018

You know what's funny?

That page is still more readable than your ugly manpages. 😁

@kenany
Copy link
Contributor

kenany commented Dec 3, 2018

A fix for this already landed in release-next: #96

@zkat
Copy link
Contributor

zkat commented Dec 6, 2018

Closing as a duplicate of #96

@zkat zkat closed this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants