Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump tar@4.4.13 to tar@6.0.5 #1868

Closed
wants to merge 1 commit into from
Closed

chore: bump tar@4.4.13 to tar@6.0.5 #1868

wants to merge 1 commit into from

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Sep 27, 2020

tar@4.4.13 has a dependency on an outdated version of fs-minipass that calls process.umask() with no arguments. That causes a runtime deprecation warning if commands such as npm ls are run either
with Node.js pending deprecations enabled or with the current Node.js 15.0.0 rc.

Update tar@4.4.13 to tar@6.0.5.

References

Related to nodejs/node#35332 (comment)
Related to #1103

@Trott Trott requested a review from a team as a code owner September 27, 2020 17:45
@Trott
chore: bump tar@4.4.13 to tar@6.0.5
462068d 
This has the benefit of removing a `process.umask()` that causes a
runtime deprecation warning if commands such as `npm ls` are run either
with Node.js pending deprecations enabled or with the current 15.0.0 RC.

Refs: nodejs/node#35332 (comment)
Refs: npm#1103
@Trott
Copy link
Contributor Author

Trott commented Sep 27, 2020

Oh, bummer. If I'm understanding the test results, it looks like latest needs to support back to Node.js 6.x, but the oldest fixed version of tar (5.0.2) requires Node.js 8.x and above, and the version here (6.0.5) requires Node.js 10.x and above.

When will latest not need to support Node.js 6.x anymore? Is there a viable path forward for this at this time if it can only support Node.js 8.x and above?

@ruyadorno
Copy link
Collaborator

Oh, bummer. If I'm understanding the test results, it looks like latest needs to support back to Node.js 6.x, but the oldest fixed version of tar (5.0.2) requires Node.js 8.x and above, and the version here (6.0.5) requires Node.js 10.x and above.

yep 👍 pretty sure that's the case

When will latest not need to support Node.js 6.x anymore?

once we land release/v7.0.0-beta back into latest 😊

@darcyclarke
Copy link
Contributor

darcyclarke commented Sep 29, 2020 •
edited

Thanks for this @Trott! Apologize though, we're probably not going to be able to land/backport this as-is against 6.x. As @ruyadorno mentioned, our plan right now is to ship npm@7 asap (which will drop support for Node versions <10 & is using tar@6.0.5). We should have a PR open against the Node.js 15.0.0 rc within the next day or two.

You can test out 7 today via npm i -g npm@next-7 or check it out here: https://github.com/npm/cli/tree/release/v7.0.0-beta. I believe the last outstanding ref to process.umask() on our end would be in lib/utils/config.js but I still think other deps may be bit by this (note: another related discussion/reference point: nodejs/node#32321)

@Trott Trott closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Trott @ruyadorno @darcyclarke