clean up flaky tests #240
Closed
clean up flaky tests #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/more-flaky-test-cleanup
branch
2 times, most recently
from
e9fd192
to
c7c7753
Compare
|
Ok, this is ready to review now. |
|
This looks like a fairly large diff so it may take a second or two to go through; I'm also finishing up a couple other tasks atm but definitely want to give this some <3 Hopefully @billatnpm will have a couple extra cycles over the next couple days to review as well. |
* Get rid of a lot of usage of osenv.tmpdir in tests. * Remove unnecessary creation/deletion of common.pkg * Reduce rimraf.sync wherever possible (often collides with common-tap.js's rimraf on windows) * Use common test utilities wherever possible. * DRY tests with test templates where it makes sense.
isaacs
force-pushed
the
isaacs/more-flaky-test-cleanup
branch
from
c7c7753
to
2f7ec52
Compare
Merged
ruyadorno
approved these changes
Oct 31, 2019
This was referenced Nov 14, 2019
This was referenced Nov 25, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osenv.tmpdirin tests.common.pkgrimraf.syncwherever possible (often collides withcommon-tap.js's rimraf on windows)