Release/v7.5.3 #2626
Merged
Release/v7.5.3 #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
release/v7.5.3
branch
from
9ba70c0
to
119c957
Compare
wraithgar
approved these changes
Feb 4, 2021
|
ah 😅 we should def cut a release of read-package-json-fast and update it here too |
- remove spawn util, refactor help command - add tests for read-user-info, minor refactor - add tests for pulse-till-done util, refactor - add tests for otplease util - add tests for open-url util - remove unused no-progress-while-running util PR-URL: #2601 Credit: @nlf Close: #2601 Reviewed-by: @ruyadorno, @wraithgar
The "do you have auth configured" only takes into consideration a hard-coded "registry" config, which means that if you don't have auth configured for the npm registry, but you do for the one you have tied to a scope elsewhere in your npmrc, we would erroneously tell you that to add a token. This uses the same method that the rest of the publish chain uses to determine which registry it would be publishing to, then sees if you have auth for THAT registry. Because that other function does a hard fallback to the npm registry, there is no more need for the exception we throw if you do not have one configured. Also, the npm cli already defaults that config item, so you can't even set it to a falsey value if you wanted
PR-URL: #2613 Credit: @nlf Close: #2613 Reviewed-by: @ljharb, @wraithgar
ruyadorno
force-pushed
the
release/v7.5.3
branch
from
119c957
to
924879f
Compare
Fixes a compatibility issue in `npm ls` due to the subtle internal change of optional dependencies being pruned from dependencies in `read-package-json-fast@2.0.0` update.
ruyadorno
force-pushed
the
release/v7.5.3
branch
from
924879f
to
b976282
Compare
ruyadorno
force-pushed
the
release/v7.5.3
branch
from
b976282
to
e815cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7.5.3 (2021-02-08)
BUG FIXES
df596bf4cfix(publish): follow all configs for registry auth check #2602 (@wraithgar)6d7afb03c#2613 install script: pass -q to curl calls to disable user .curlrc files (@nlf)DEPENDENCIES
3294fed6fpacote@11.2.50f7a3a87cread-package-json-fast@2.0.16f46b0f7finit-package-json@2.0.2df4f65acc@npmcli/arborist@2.2.07038c2ff4@npmcli/run-script@1.8.254cd4c87alibnpmversion@1.0.89ab36aae4graceful-fs@4.2.5e1822cf27@npmcli/installed-package-contents@1.0.7