Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve circular dependency in pack.js #266

Closed
wants to merge 1 commit into from
Closed

fix: resolve circular dependency in pack.js #266

wants to merge 1 commit into from

Commits on Oct 11, 2019

  1. fix: resolve circular dependency in pack.js 

    `lib/pack.js` and `lib/config/figgy-config.js` load each other,
making `figgy-config.js` grab the original `module.exports` value
and not the intended one. In particular, this always sets the
`dirPacker` value to `undefined` in the config generation step.

Fix this by setting `module.exports` early.

Refs: nodejs/node#29935
    @addaleax
    addaleax committed Oct 11, 2019
    Copy the full SHA
    2f2bde7 View commit details
    Browse the repository at this point in the history