Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] rewrite doctor tests to dictate the current node version #2681

Merged
merged 11 commits into from Feb 12, 2021

Commits on Feb 11, 2021

  1. fix(env): Do not clobber defined 'env' script

    If an env script is already defined, run that
    instead of the default.
    
    PR-URL: npm#2655
    Credit: @isaacs
    Close: npm#2655
    Reviewed-by: @ljharb
    isaacs authored and wraithgar committed Feb 11, 2021
    Copy the full SHA
    ef687f5 View commit details
    Browse the repository at this point in the history
  2. fix(docs): fix angle brackets in npm diff docs

    Emphasizing them like we do everywhere else to fix encoding errors and
    for consistency.
    
    Also removed the `<String>` from the type definition as we don't do that
    anywhere else.
    
    PR-URL: npm#2662
    Credit: @ethomson
    Close: npm#2662
    Reviewed-by: @wraithgar
    ethomson authored and wraithgar committed Feb 11, 2021
    Copy the full SHA
    7e1e841 View commit details
    Browse the repository at this point in the history
  3. fix(package.json): resetdeps

    This brought in @npmcli/installed-package-contents@1.0.7 from
    commit e1822cf
    wraithgar committed Feb 11, 2021
    Copy the full SHA
    14dd938 View commit details
    Browse the repository at this point in the history
  4. graceful-fs@4.2.6

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    39e4a64 View commit details
    Browse the repository at this point in the history
  5. eslint-plugin-promise@4.3.1

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    96dffab View commit details
    Browse the repository at this point in the history
  6. @npmcli/run-script@1.8.3

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    9a6e9d3 View commit details
    Browse the repository at this point in the history
  7. @npmcli/git@2.0.5

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    584b746 View commit details
    Browse the repository at this point in the history
  8. make-fetch-happen@8.0.14

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    6305ebd View commit details
    Browse the repository at this point in the history
  9. libnpmversion@1.0.10

    wraithgar committed Feb 11, 2021
    Copy the full SHA
    e998811 View commit details
    Browse the repository at this point in the history
  10. chore(package-lock): rebuild package-lock

    This pulls in, installs, and de-dupes our subdependencies.
    Notable updates are promise-retry and @npmcli/move-file which
    had new versions but we had no way to update and/or dedupe
    
    We also manually removed uuid from our package.json which was
    only added in the past to try to get around this same deduping
    issue
    wraithgar committed Feb 11, 2021
    Copy the full SHA
    554d91c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. fix(tests): rewrite doctor tests

    This decouples our tests from depending on the node version being right, and
    allows us to run in all of the environments we need to during CI.
    
    PR-URL: npm#2681
    Credit: @ljharb
    Close: npm#2681
    Reviewed-by: @wraithgar
    ljharb authored and wraithgar committed Feb 12, 2021
    Copy the full SHA
    3a159d2 View commit details
    Browse the repository at this point in the history